RockteMQ-AI commented on issue #2953: URL: https://github.com/apache/rocketmq-dashboard/issues/2953#issuecomment-5502835746
**Issue Evaluation** Category: `bug` | Status: **Confirmed** The reported issue has been verified against the codebase on the `pr-2533-review` branch. **Root Cause:** `OperationAuditService.record()` calls `auditMapper.insert(audit)` without a try-catch guard. Multiple callers (`AlertService`, `NotificationOutboxService`, `AlertSilenceService`, `InstanceService`, `AclService`) invoke `record()` after the business operation has already completed. If the audit insert fails (e.g. DB timeout, constraint violation), the exception propagates to the caller and the API reports failure even though the business action already succeeded. **Impact:** Operators may retry a completed action; notification processing can report misleading failure status. **Severity:** medium **Suggested Fix:** Wrap `auditMapper.insert()` in a try-catch inside `OperationAuditService.record()`, log the failure at WARN level, and return without throwing. Add a regression test verifying that a mapper failure does not propagate. An automated fix proposal can be generated. Reply `/approve` to proceed with PR generation. --- *Automated evaluation by RockteMQ-AI* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
