yyqdbngt opened a new pull request, #2946:
URL: https://github.com/apache/rocketmq-dashboard/pull/2946
## Summary
- `AuditService` rejects `result` filter values outside the recorded
vocabulary with a 400 before querying
- accept only `SUCCESS`/`FAILED` (or an absent filter) on both the paged
query and the CSV export
- add regression coverage for accepted and rejected result filters
## Why
Every `record` call site in the codebase writes either `SUCCESS` or `FAILED`
to the audit result column, but the query layer passed the user-supplied
`result` filter straight into `.eq("result", ...)`. A filter such as `success`
or `PARTIAL` therefore returned a silent empty page instead of surfacing a
validation error, which reads like "no audit history" to the user. The display
layer was already normalized in the web fix for audit timestamps; this closes
the same gap on the Java query side.
## Testing
- `cd server && mvn -q -Dtest=AuditServiceTest test` — all tests pass,
including the new `queryLogsRejectsResultFiltersOutsideTheRecordedVocabulary`
and `queryLogsAcceptsEveryRecordedResultValue`
- `cd server && mvn -q
-Dtest=AuditControllerTest,MybatisPlusAuditRepositoryTest test` — all tests
pass (regression for the audit endpoints)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
