yyqdbngt opened a new pull request, #2932:
URL: https://github.com/apache/rocketmq-dashboard/pull/2932

   ## Summary
   - bound `BatchDeleteInstancesDTO.ids` with `@Size(max = 100)`, matching the 
batch limits used by every other bulk endpoint
   - add an explicit `@NotEmpty` message and bean-validation regression tests
   
   ## Why
   The batch instance delete accepted an unbounded identifier list: only 
`@NotEmpty` was present, while the bulk rule toggle/delete, the DLQ selected 
resend, and the topic/group import endpoints all cap their selection at 100. 
Since `InstanceService.deleteInstances` fans out one provider call per 
identifier, an oversized batch could run away unbounded. The 100-id bound 
matches the established convention in this codebase.
   
   ## Testing
   - `cd server && mvn -q -Dtest=BatchDeleteInstancesDTOTest test` — 3 tests 
pass (new class)
   - `cd server && mvn -q -Dtest=InstanceServiceTest test` — all tests pass 
(regression for the delete flow)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to