yyqdbngt opened a new pull request, #2928: URL: https://github.com/apache/rocketmq-dashboard/pull/2928
## Summary - map `whiteRemoteAddress` in `MybatisPlusAclRepository.toUserEntity` so the generic user upsert path persists the whitelist - add capture-based regression tests for `saveUser` and `replaceUser` ## Why `toUserVO` reads `white_remote_address` from the row, but `toUserEntity` never wrote it back: every upsert through the generic `saveUser`/`replaceUser` path silently dropped the whitelist carried on the VO. The plain-access endpoint worked around this by building its entity manually, but any caller of the generic upsert with a set whitelist lost it without an error. Existing `updateUser` behavior is unchanged because the merged VO carries a null whitelist and MyBatis-Plus omits null fields from `updateById`. ## Testing - `cd server && mvn -q -Dtest=MybatisPlusAclRepositoryTest test` — all tests pass, including the new `saveUserShouldPersistTheWhiteRemoteAddress` and `replaceUserShouldCarryTheWhiteRemoteAddressIntoTheUpdate` - `cd server && mvn -q -Dtest=AclServiceTest test` — all tests pass (regression for the update flow) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
