RockteMQ-AI commented on issue #2915:
URL: 
https://github.com/apache/rocketmq-dashboard/issues/2915#issuecomment-5498239504

   **Issue Evaluation**
   
   Category: `enhancement` | Status: **Evaluated**
   
   Note: The issue references `BrokerConfigDiffService`, but the actual class 
in the codebase is `NameServerConfigDiffService`. The observation about losing 
error details is valid for this class.
   
   **Analysis:** When `NameServerConfigDiffService` catches a 
`BusinessException` during broker config read, the exception message is 
discarded:
   
   ```java
   } catch (BusinessException exception) {
       nodes.add(NameServerConfigDiffVO.NodeStatusVO.builder()
               .address(address)
               .reachable(false)
               .build());
   }
   ```
   
   The `NodeStatusVO` currently only has `address` and `reachable` fields — no 
`message` field exists.
   
   **Feasibility:** Feasible. Would require:
   1. Adding a `message` field to `NodeStatusVO.NodeStatusVO`
   2. Populating it with `exception.getMessage()` in the catch block
   3. Updating the frontend cluster page to display the message
   
   **Scope:** `NameServerConfigDiffService`, `NameServerConfigDiffVO`, and the 
cluster page frontend component.
   
   ---
   *Automated evaluation by RockteMQ-AI*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to