yyqdbngt opened a new pull request, #2867:
URL: https://github.com/apache/rocketmq-dashboard/pull/2867
## Summary
- Normalize the optional `k8sNamespace`/`k8sId` identifiers in
`NameserverRegistryService.create`/`update`: surrounding whitespace is
trimmed and a
blank value is stored as `null` ("unset"), mirroring the already-documented
normalization of the registry `name`.
- Added regression tests for trim-on-create, blank-means-unset-on-create and
normalization-on-update.
## Why
Registry names are compared and displayed as-is, so `create` already trims
them with an
explicit rationale against near-duplicate entries. The k8s identifiers —
which locate
cluster resources and are compared for lookups — were stored verbatim, so
`"prod "` and
`"prod"` (or `" "`) were accepted as distinct, non-null values. The k8s
certificate
service applies the same trim-and-null treatment to its identifiers
(`normalizeOptionalIdentity`); this brings the nameserver registry in line
with it.
## Testing
- `cd server && mvn -Dtest=NameserverRegistryServiceTest test`
— Tests run: 23, Failures: 0, Errors: 0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
