btlqql commented on PR #1374: URL: https://github.com/apache/rocketmq-dashboard/pull/1374#issuecomment-5404265038
Rebased onto the latest `rocketmq-studio` and completed the schema refresh requested in the review. This update goes beyond a textual conflict resolution because the persistence schema changed materially after #2317: - V1 is regenerated from the current schema. - V2 safely upgrades the standardized numeric-ID layout and preserves topic/group ownership, Kubernetes certificate identity and ACL rows. - pre-#2317 VARCHAR/UUID-ID layouts are explicitly rejected before legacy-row rewrites instead of attempting an unsafe implicit key conversion. - the compatibility boundary is documented in the root, Chinese and deployment guides. - integration coverage now includes fresh, numeric-upgrade and unsupported-layout paths. Validation: - `mvn -Dtest=MySqlMigrationIntegrationTest test` compiled successfully; Testcontainers was skipped locally because Docker was unavailable - direct MySQL 8.0.45 runs validated fresh creation, row-preserving numeric upgrade, and guarded rejection of the unsupported layout - `mvn checkstyle:check` and `git diff --check` passed @lizhimins, could you please re-review this updated migration boundary and implementation? @RockteMQ-AI, please re-review the new commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
