RockteMQ-AI commented on issue #2115: URL: https://github.com/apache/rocketmq-dashboard/issues/2115#issuecomment-5281491590
**Issue Evaluation** Category: `bug` | Status: **Confirmed** The reported issue has been verified against the current codebase. **Root Cause:** `AlertService` uses update-only persistence for direct rule updates and bulk toggles, but singular rule toggle and system alert acknowledgement still call upsert-style save methods after loading a snapshot. A concurrent delete can therefore recreate the removed row (same TOCTOU pattern as #2116). **Impact:** Deleted alerts/rules can be silently recreated, causing phantom alert rules and inconsistent audit state. **Severity:** Medium — same race condition pattern as #2116, affecting alert management. **Proposed Fix:** 1. Use update-only repository operations for singular rule toggle and system alert acknowledgement 2. Return 404 when the row disappeared 3. Skip success audit in the 404 case 4. Add focused tests for the race condition An automated fix proposal will be generated. Reply `/approve` to proceed with PR generation. --- *Automated evaluation by github-manager-bot* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
