lizhimins commented on code in PR #10590:
URL: https://github.com/apache/rocketmq/pull/10590#discussion_r3608090678
##########
tools/src/main/java/org/apache/rocketmq/tools/command/message/DecodeMessageIdCommand.java:
##########
@@ -50,14 +50,8 @@ public void execute(final CommandLine commandLine, final
Options options,
String messageId = commandLine.getOptionValue('i').trim();
try {
- System.out.printf("ip=%s",
MessageClientIDSetter.getIPStrFromID(messageId));
- } catch (Exception e) {
- e.printStackTrace();
- }
-
- try {
- String date =
UtilAll.formatDate(MessageClientIDSetter.getNearlyTimeFromID(messageId),
UtilAll.YYYY_MM_DD_HH_MM_SS_SSS);
- System.out.printf("date=%s", date);
+ System.out.printf("IP: %s%n",
MessageClientIDSetter.getIPStrFromID(messageId));
+ System.out.printf("Date: %s%n",
UtilAll.formatDate(MessageClientIDSetter.getNearlyTimeFromID(messageId),
UtilAll.YYYY_MM_DD_HH_MM_SS_SSS));
Review Comment:
It is recommended to perform a complete parsing of the offsetId field
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
