huanzhikang opened a new issue, #9491: URL: https://github.com/apache/rocketmq/issues/9491
### Before Creating the Enhancement Request - [x] I have confirmed that this should be classified as an enhancement rather than a bug/feature. ### Summary Remove the volatile declaration for the two variables requestsWrite and requestsRead in the GroupCommitService class. Reasons: The variable requestsRead is only used within the GroupCommitService thread, so visibility is not required, and it does not need to be declared as volatile. The code that uses the requestsWrite object is all between lock and unlock operations. The CAS (Compare-And-Swap) operations in lock and unlock have the memory semantics of volatile read and write, which already ensures the visibility of the requestsWrite object reference. Therefore, it also does not need to be declared as volatile. ### Motivation Reomve unneeded volatile declarations ### Describe the Solution You'd Like Remove the volatile declaration for the two variables requestsWrite and requestsRead in the GroupCommitService class ### Describe Alternatives You've Considered Remove the volatile declaration for the two variables requestsWrite and requestsRead in the GroupCommitService class ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
