qianye1001 commented on code in PR #9483:
URL: https://github.com/apache/rocketmq/pull/9483#discussion_r2151559157
##########
proxy/src/main/java/org/apache/rocketmq/proxy/grpc/GrpcServer.java:
##########
@@ -46,10 +57,26 @@ public void start() throws Exception {
public void shutdown() {
try {
+ // Unregister the TLS context reload handler
+
TlsCertificateManager.getInstance().unregisterReloadListener(this.tlsReloadHandler);
+
this.server.shutdown().awaitTermination(timeout, unit);
+
log.info("grpc server shutdown successfully.");
} catch (Exception e) {
- e.printStackTrace();
+ log.error("Failed to shutdown grpc server", e);
+ }
+ }
+
+ static class GrpcTlsReloadHandler implements
TlsCertificateManager.TlsContextReloadListener {
Review Comment:
no static
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
