Crazylychee opened a new pull request, #9440:
URL: https://github.com/apache/rocketmq/pull/9440

   
   
   <!-- Please make sure the target branch is right. In most case, the target 
branch should be `develop`. -->
   
   ### Which Issue(s) This PR Fixes
   
   Fixes #9439
   
   ### Brief Description
   
   feat: Add backslash escaping to MixAll.properties2String
   
   Introduced a new `escapeBackslashes` parameter to `MixAll.properties2String` 
to enable proper escaping of backslashes in property values.
   
   This enhancement addresses issues where file paths or other string values 
containing backslashes (e.g., `C:\path\to\file`) were incorrectly represented 
in the generated configuration string. By double-escaping backslashes (e.g., 
`C:\\path\\to\\file`), the output string now correctly reflects the intended 
literal backslash characters, which is crucial for persistence and 
interoperability with systems that expect escaped path delimiters.
   
   The `Configuration` class's `getAllConfigsInternal()` method has been 
updated to utilize this new parameter, ensuring that all stored configurations 
are persisted with correctly escaped backslashes in their string representation.
   
   Affected files:
   - `MixAll.java`: Modified `properties2String` method signatures and added 
escaping logic.
   - `Configuration.java`: Updated `getAllConfigsInternal()` to pass `true` for 
`escapeBackslashes`.
   
   ### How Did You Test This Change?
   
   
![image](https://github.com/user-attachments/assets/87e5ea27-dfaf-49f5-ad1c-e15ed2f6059b)
   The above is before the modification, you can see the bug. The following is 
after the modification, you can see the program returns normally.
   
![image](https://github.com/user-attachments/assets/2be07ec3-b215-4417-ab55-d5ae91fb4181)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to