Guiqu1aixi opened a new issue, #9428:
URL: https://github.com/apache/rocketmq/issues/9428

   ### Before Creating the Enhancement Request
   
   - [x] I have confirmed that this should be classified as an enhancement 
rather than a bug/feature.
   
   
   ### Summary
   
   I think there is no significant difference between logging a warning every 
1000 times versus every 1024 times. However, changing 1000 to 1024 allows 
replacing the modulo operation with a bitwise and operation, which can achieve 
a performance optimization in every calculation cycle, Thank you for your 
patience in reviewing this。
   中文:每1000次记录一次警告和每1024次之间没有显著差异,但改为1024次后可以用位与操作代替取模运算,从而在每次计算周期中优化性能,谢谢您的耐心查看
   
   https://github.com/apache/rocketmq/pull/9427
   
   T
   
   ### Motivation
   
   
org.apache.rocketmq.client.impl.consumer.DefaultLitePullConsumerImpl.PullTaskImpl#run
   提升此处代码的性能
   
   ### Describe the Solution You'd Like
   
   I think there is no significant difference between logging a warning every 
1000 times versus every 1024 times. However, changing 1000 to 1024 allows 
replacing the modulo operation with a bitwise and operation, which can achieve 
a performance optimization in every calculation cycle.
   
   ### Describe Alternatives You've Considered
   
   changing 1000 to 1024 allows replacing the modulo operation with a bitwise 
and operation
   
   https://github.com/apache/rocketmq/pull/9427
   
   ### Additional Context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to