lollipopjin commented on code in PR #9256:
URL: https://github.com/apache/rocketmq/pull/9256#discussion_r2053517379
##########
store/src/main/java/org/apache/rocketmq/store/metrics/RocksDBStoreMetricsManager.java:
##########
@@ -78,50 +78,62 @@ public static List<Pair<InstrumentSelector, ViewBuilder>>
getMetricsView() {
}
public static void init(Meter meter, Supplier<AttributesBuilder>
attributesBuilderSupplier,
- RocksDBMessageStore messageStore) {
+ ConsumeQueueStoreInterface consumeQueueStore) {
+
+ RocksDBConsumeQueueStore rocksDBMessageStore;
+ if (consumeQueueStore instanceof RocksDBConsumeQueueStore) {
Review Comment:
init with null for readability improve.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
