redlsz commented on code in PR #9255:
URL: https://github.com/apache/rocketmq/pull/9255#discussion_r2009808135
##########
proxy/src/main/java/org/apache/rocketmq/proxy/grpc/v2/consumer/ReceiveMessageActivity.java:
##########
@@ -135,14 +136,22 @@ public void receiveMessage(ProxyContext ctx,
ReceiveMessageRequest request,
).thenAccept(popResult -> {
if (proxyConfig.isEnableProxyAutoRenew() &&
request.getAutoRenew()) {
if (PopStatus.FOUND.equals(popResult.getPopStatus())) {
+ GrpcClientChannel clientChannel =
grpcChannelManager.getChannel(ctx.getClientID());
+ if (clientChannel == null) {
+ RuntimeException e = new RuntimeException(
Review Comment:
> RuntimeException will be convert to INTERNAL_SERVER_ERROR, It is
recommended to use GrpcProxyException to return ok and carry error messages
Fixed. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
