ltamber commented on code in PR #711:
URL: https://github.com/apache/rocketmq-spring/pull/711#discussion_r1992872345
##########
rocketmq-v5-client-spring-boot/src/main/java/org/apache/rocketmq/client/core/RocketMQClientTemplate.java:
##########
@@ -221,21 +221,14 @@ public SendReceipt syncSendNormalMessage(String
destination, byte[] payload) {
*/
public SendReceipt syncSendGrpcMessage(String destination, Message<?>
message, Duration messageDelayTime, String messageGroup) {
if (Objects.isNull(message) || Objects.isNull(message.getPayload())) {
- log.error("send request message failed. destination:{}, message is
null ", destination);
throw new IllegalArgumentException("`message` and
`message.payload` cannot be null");
}
SendReceipt sendReceipt = null;
try {
org.apache.rocketmq.client.apis.message.Message rocketMsg =
this.createRocketMQMessage(destination, message, messageDelayTime,
messageGroup);
Producer grpcProducer = this.getProducer();
- try {
- sendReceipt = grpcProducer.send(rocketMsg);
- log.info("Send message successfully, messageId={}",
sendReceipt.getMessageId());
- } catch (Throwable t) {
- log.error("Failed to send message", t);
- }
+ sendReceipt = grpcProducer.send(rocketMsg);
Review Comment:
Can we just return `grpcProducer.send()` result directly here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
