SevenBlue2018 commented on code in PR #712:
URL: https://github.com/apache/rocketmq-spring/pull/712#discussion_r1992609075
##########
rocketmq-v5-client-spring-boot/src/main/java/org/apache/rocketmq/client/autoconfigure/ExtConsumerResetConfiguration.java:
##########
@@ -103,10 +102,12 @@ private void registerTemplate(String beanName, Object
bean) {
rocketMQTemplate.setSimpleConsumerBuilder(consumerBuilder);
rocketMQTemplate.setSimpleConsumer(simpleConsumer);
rocketMQTemplate.setMessageConverter(rocketMQMessageConverter.getMessageConverter());
- log.info("Set real simpleConsumer to :{} {}", beanName,
annotation.value());
+ String topic = environment.resolvePlaceholders(annotation.topic());
+ log.info("Set real simpleConsumer to {} using {} topic", beanName,
topic);
Review Comment:
Why not refer to the implementation of PushConsumer？We need log each key
attribute
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
