lizhimins commented on code in PR #9218:
URL: https://github.com/apache/rocketmq/pull/9218#discussion_r1976837824
##########
broker/src/main/java/org/apache/rocketmq/broker/metrics/ConsumerLagCalculator.java:
##########
@@ -456,14 +456,11 @@ public long getAvailableMsgCount(String group, String
topic, int queueId, boolea
}
long pullOffset;
- if (isPop) {
+ if (isPop && !brokerConfig.isPopConsumerKVServiceEnable()) {
pullOffset = popBufferMergeService.getLatestOffset(topic, group,
queueId);
if (pullOffset < 0) {
pullOffset = offsetManager.queryOffset(group, topic, queueId);
}
- if (pullOffset < 0) {
Review Comment:
There is another duplicate judgment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
