3424672656 commented on code in PR #9194:
URL: https://github.com/apache/rocketmq/pull/9194#discussion_r1967091052
##########
broker/src/main/java/org/apache/rocketmq/broker/client/rebalance/RebalanceLockManager.java:
##########
@@ -55,24 +55,18 @@ public boolean tryLock(final String group, final
MessageQueue mq, final String c
try {
this.lock.lockInterruptibly();
try {
- ConcurrentHashMap<MessageQueue, LockEntry> groupValue =
this.mqLockTable.get(group);
- if (null == groupValue) {
- groupValue = new ConcurrentHashMap<>(32);
- this.mqLockTable.put(group, groupValue);
- }
+ ConcurrentHashMap<MessageQueue, LockEntry> groupValue =
this.mqLockTable.computeIfAbsent(group,
+ k -> new ConcurrentHashMap<>(32));
LockEntry lockEntry = groupValue.get(mq);
if (null == lockEntry) {
lockEntry = new LockEntry();
lockEntry.setClientId(clientId);
+
lockEntry.setLastUpdateTimestamp(System.currentTimeMillis());
Review Comment:
Since the lock should have been acquired by the current thread during
initialization, setting updatetime means that the lock was acquired
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
