qianye1001 commented on code in PR #9162: URL: https://github.com/apache/rocketmq/pull/9162#discussion_r1946035565
########## broker/src/main/java/org/apache/rocketmq/broker/AdminAsyncTaskManager.java: ########## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.rocketmq.broker; + +import com.alibaba.fastjson.JSON; +import java.util.concurrent.CompletableFuture; +import org.apache.rocketmq.common.AsyncTask; + +import java.util.ArrayList; +import java.util.Collections; +import java.util.List; +import java.util.UUID; +import java.util.concurrent.ConcurrentHashMap; + +import com.github.benmanes.caffeine.cache.Cache; +import com.github.benmanes.caffeine.cache.Caffeine; +import java.util.concurrent.TimeUnit; +import org.apache.rocketmq.common.TaskStatus; + +public class AdminAsyncTaskManager { + + // taskId -> AsyncTask + private final Cache<String, AsyncTask> asyncTaskCache; + + // taskName -> taskId + private final ConcurrentHashMap<String, List<String>> taskNameToIdsMap; + + public AdminAsyncTaskManager() { + this.asyncTaskCache = Caffeine.newBuilder() + .expireAfterWrite(30, TimeUnit.MINUTES) + .maximumSize(10000) + .build(); + + this.taskNameToIdsMap = new ConcurrentHashMap<>(); + } + + /** + * Creates a new asynchronous task with a unique taskId. + * + * @param taskName The name of the task. + * @param future The CompletableFuture representing the asynchronous task. + * @return The generated taskId. + */ + public String createTask(String taskName, CompletableFuture<?> future) { + String taskId = UUID.randomUUID().toString(); + AsyncTask task = new AsyncTask(taskName, taskId, future); + + asyncTaskCache.put(taskId, task); + taskNameToIdsMap.computeIfAbsent(taskName, k -> new ArrayList<>()).add(taskId); Review Comment: make sure [ add and remove object in ArrayList ] in map.compute to avoid concurrent errors -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
