lizhimins commented on code in PR #9142: URL: https://github.com/apache/rocketmq/pull/9142#discussion_r1922015848
########## store/src/main/java/org/apache/rocketmq/store/timer/rocksdb/TimerMessageKVStore.java: ########## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.rocketmq.store.timer.rocksdb; + +import java.util.List; + +public interface TimerMessageKVStore { + + /** + * Start the timer message kv store. + */ + boolean start(); + + /** + * Shutdown the timer message kv store. + */ + boolean shutdown(); + + /** + * Get the file path of the timer message kv store. + */ + String getFilePath(); + + /** + * Write the timer message records to the timer message kv store. + * @param consumerRecordList the list of timer message records to be written. + * @param offset the cq offset of the timer message records to be written. + * @param timestamp the key of the timer message metric column family. + * Default is store common timer message. + */ + void writeDefaultRecords(List<TimerMessageRecord> consumerRecordList, long offset, int timestamp); Review Comment: 减少接口数量，Less is More -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
