caigy commented on code in PR #8788:
URL: https://github.com/apache/rocketmq/pull/8788#discussion_r1919456531


##########
distribution/bin/runbroker.sh:
##########
@@ -57,6 +57,17 @@ export 
CLASSPATH=.:${BASE_DIR}/conf:${BASE_DIR}/lib/*:${CLASSPATH}
 # The RAMDisk initializing size in MB on Darwin OS for gc-log
 DIR_SIZE_IN_MB=600
 
+if [ "$JVM_OPT_XMX" = "" ]; then
+   export JVM_OPT_XMX="8g"
+fi
+if [ "$JVM_OPT_XMS" = "" ]; then
+    export JVM_OPT_XMS="8g"
+fi
+
+if [ "$JVM_OPT_XMN" = "" ]; then
+    export JVM_OPT_XMN="4g"

Review Comment:
   Are these variables used by any subsequent commands in other scripts? If 
not, `export` is unnecessary.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to