3424672656 commented on code in PR #126:
URL: https://github.com/apache/rocketmq-flink/pull/126#discussion_r1911912687
##########
src/main/java/org/apache/flink/connector/rocketmq/source/enumerator/RocketMQSourceEnumerator.java:
##########
@@ -69,18 +79,30 @@ public class RocketMQSourceEnumerator
private final OffsetsSelector startingOffsetsSelector;
private final OffsetsSelector stoppingOffsetsSelector;
+ // Used for queue dynamic allocation
+ private final Map<MessageQueue, Long> checkedOffsets;
+ private boolean[] initTask;
+
// The internal states of the enumerator.
// This set is only accessed by the partition discovery callable in the
callAsync() method.
// The current assignment by reader id. Only accessed by the coordinator
thread.
// The discovered and initialized partition splits that are waiting for
owner reader to be
// ready.
- private final Set<MessageQueue> allocatedSet;
+ private final Map<MessageQueue, Byte> allocatedSet;
Review Comment:
This object may be manipulated by multiple threads
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
