PleaseGiveMeTheCoke opened a new issue, #9081:
URL: https://github.com/apache/rocketmq/issues/9081

   ### Before Creating the Enhancement Request
   
   - [X] I have confirmed that this should be classified as an enhancement 
rather than a bug/feature.
   
   
   ### Summary
   
   createChannelAsync方法的一开始 ,执行了get操作
   
![image](https://github.com/user-attachments/assets/4d19c372-a994-439d-8bdf-b6ccfd03f978)
   而createChannelAsync方法的调用方**getAndCreate**ChannelAsync方法中,已经执行过同样的get操作了。这段 
get 操作不应该在 createChannelAsync方法中进行,因为这个方法的命名是 **create**ChannelAsync。
   
   
![image](https://github.com/user-attachments/assets/271b14ce-68b6-420e-8f56-cc8ff7a3230d)
   
   
   
   ### Motivation
   
   1. 目前getAndCreateChannelAsync方法相当于执行了两次同样的get操作
   2. 目前createChannelAsync的方法命名和具体职责存在不一致
   3. 优化后可以提升性能(少了一次get操作),提高代码的可读性
   
   ### Describe the Solution You'd Like
   
   删除下面的代码
   
![image](https://github.com/user-attachments/assets/90e86627-9bee-45de-98bf-5a2219c2764a)
   
   并在该方法的另一处调用方getAndCreateNameserverChannelAsync中,调用之前加上get操作
   
   
![image](https://github.com/user-attachments/assets/9c878a95-9ac0-49ad-b062-958f949efdff)
   
   
   ### Describe Alternatives You've Considered
   
   无
   
   ### Additional Context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to