lizhimins commented on code in PR #9071:
URL: https://github.com/apache/rocketmq/pull/9071#discussion_r1893751253


##########
tieredstore/src/main/java/org/apache/rocketmq/tieredstore/core/MessageStoreDispatcherImpl.java:
##########
@@ -153,10 +160,22 @@ public CompletableFuture<Boolean> 
doScheduleDispatch(FlatFileInterface flatFile,
 
             // If the previous commit fails, attempt to trigger a commit 
directly.
             if (commitOffset < currentOffset) {
-                this.commitAsync(flatFile);
+                this.commitAsync(flatFile).whenComplete((result, throwable) -> 
{
+                    if (throwable != null) {
+                        log.error("topic: {}, queueId: {} flat file flush 
cache failed more than twice.", topic, queueId, throwable);

Review Comment:
   要不全用 = 保持一下风格一致,报错信息在前面



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to