lizhimins commented on code in PR #9048:
URL: https://github.com/apache/rocketmq/pull/9048#discussion_r1884964893


##########
broker/src/main/java/org/apache/rocketmq/broker/processor/PopMessageProcessor.java:
##########
@@ -213,27 +218,26 @@ public void notifyMessageArriving(final String topic, 
final int queueId, final S
     @Override
     public RemotingCommand processRequest(final ChannelHandlerContext ctx, 
RemotingCommand request)
         throws RemotingCommandException {
+
         final long beginTimeMills = 
this.brokerController.getMessageStore().now();
+
+        // fill bron time to properties if not exist, why we need this?
         request.addExtFieldIfNotExist(BORN_TIME, 
String.valueOf(System.currentTimeMillis()));
         if (Objects.equals(request.getExtFields().get(BORN_TIME), "0")) {

Review Comment:
   I use put if not exist method here. This code is equivalent to the original. 
Maybe there was originally a value of 0? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to