RongtongJin commented on code in PR #8989:
URL: https://github.com/apache/rocketmq/pull/8989#discussion_r1858106186


##########
store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java:
##########
@@ -2793,6 +2797,7 @@ public void 
notifyMessageArriveIfNecessary(DispatchRequest dispatchRequest) {
     class ReputMessageService extends ServiceThread {
 
         protected volatile long reputFromOffset = 0;
+        protected volatile long currentReputTimestamp = 0;

Review Comment:
   Should the initial value be set to the current time? If it's set to 0, would 
it retrieve an unexpectedly large value before being assigned?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to