lizhanhui commented on code in PR #8915:
URL: https://github.com/apache/rocketmq/pull/8915#discussion_r1842045934
##########
common/src/main/java/org/apache/rocketmq/common/config/AbstractRocksDBStorage.java:
##########
@@ -121,14 +121,16 @@ protected void initWriteOptions() {
this.writeOptions = new WriteOptions();
this.writeOptions.setSync(false);
this.writeOptions.setDisableWAL(true);
- this.writeOptions.setNoSlowdown(true);
+ // https://github.com/facebook/rocksdb/wiki/Write-Stalls
+ this.writeOptions.setNoSlowdown(false);
}
protected void initAbleWalWriteOptions() {
this.ableWalWriteOptions = new WriteOptions();
this.ableWalWriteOptions.setSync(false);
this.ableWalWriteOptions.setDisableWAL(false);
- this.ableWalWriteOptions.setNoSlowdown(true);
+ // https://github.com/facebook/rocksdb/wiki/Write-Stalls
+ this.ableWalWriteOptions.setNoSlowdown(false);
Review Comment:
Checkout the RocksGroupCommitService, the group-commit thread is
responsible for triggering and await batch-write to RocksDB; If the
group-commit buffer[bounded, 100k, by default] is full, back-pressure the main
dispatch thread, hence the dispatch-lag metrics alarms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
