lollipopjin commented on code in PR #8919:
URL: https://github.com/apache/rocketmq/pull/8919#discussion_r1841709005
##########
common/src/main/java/org/apache/rocketmq/common/constant/PermName.java:
##########
@@ -68,4 +68,8 @@ public static boolean isValid(final int perm) {
public static boolean isPriority(final int perm) {
return (perm & PERM_PRIORITY) == PERM_PRIORITY;
}
+
Review Comment:
how about change method name to isInAccessable()?
and use !isReadable(xxx) && !isWriteable(xxx) to mark this.
##########
proxy/src/main/java/org/apache/rocketmq/proxy/grpc/v2/route/RouteActivity.java:
##########
@@ -252,6 +253,8 @@ protected List<MessageQueue>
genMessageQueueFromQueueData(QueueData queueData, R
w = queueData.getWriteQueueNums();
} else if (PermName.isReadable(queueData.getPerm())) {
r = queueData.getReadQueueNums();
+ } else if (PermName.isNone(queueData.getPerm())) {
Review Comment:
add unit tests for n case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
