lizhanhui commented on code in PR #8891:
URL: https://github.com/apache/rocketmq/pull/8891#discussion_r1829070310
##########
broker/src/main/java/org/apache/rocketmq/broker/config/v2/SubscriptionGroupManagerV2.java:
##########
@@ -72,7 +72,7 @@ private boolean loadSubscriptions() {
while (iterator.isValid()) {
SubscriptionGroupConfig subscriptionGroupConfig =
parseSubscription(iterator.key(), iterator.value());
if (null != subscriptionGroupConfig) {
-
super.updateSubscriptionGroupConfigWithoutPersist(subscriptionGroupConfig);
+ super.putSubscriptionGroupConfig(subscriptionGroupConfig);
Review Comment:
We are actually loading existing config from persistence kv store, not
updating.
Given there may be a lot of items while reboot loading, log this may flood
the log files unnecessarily.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
