This is an automated email from the ASF dual-hosted git repository.

jinrongtong pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git


The following commit(s) were added to refs/heads/develop by this push:
     new fe8077250b [ISSUE #8875] Fix HAConnection leak
fe8077250b is described below

commit fe8077250b790ea7ff9184ce1752513f9bd3d6de
Author: Crazywen <xnxx...@163.com>
AuthorDate: Wed Oct 30 16:42:30 2024 +0800

    [ISSUE #8875] Fix HAConnection leak
---
 store/src/main/java/org/apache/rocketmq/store/ha/DefaultHAService.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/store/src/main/java/org/apache/rocketmq/store/ha/DefaultHAService.java 
b/store/src/main/java/org/apache/rocketmq/store/ha/DefaultHAService.java
index 75e0afa4e8..c0e203862c 100644
--- a/store/src/main/java/org/apache/rocketmq/store/ha/DefaultHAService.java
+++ b/store/src/main/java/org/apache/rocketmq/store/ha/DefaultHAService.java
@@ -350,8 +350,8 @@ public class DefaultHAService implements HAService {
                                         + 
sc.socket().getRemoteSocketAddress());
                                     try {
                                         HAConnection conn = 
createConnection(sc);
-                                        conn.start();
                                         
DefaultHAService.this.addConnection(conn);
+                                        conn.start();
                                     } catch (Exception e) {
                                         log.error("new HAConnection 
exception", e);
                                         sc.close();

Reply via email to