Re: [PR] [ISSUE #8380]fix wrong election in controllerMode [rocketmq]

[via GitHub]

Willhow-Gao commented on PR #8383:
URL: https://github.com/apache/rocketmq/pull/8383#issuecomment-2267257720

   > > > Thanks for your contributions! By the way, how about adding unit tests 
to cover this code path?
   > > 
   > > 
   > > well, i will add unit test
   > 
   > Great! But could u fix these wrong codestyles in your new code for passing 
the checks. <img alt="image" width="1493" 
src="https://private-user-images.githubusercontent.com/87409330/354839786-7892989b-e892-4961-89be-8c2d5beba3f3.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjI3MzEzMzIsIm5iZiI6MTcyMjczMTAzMiwicGF0aCI6Ii84NzQwOTMzMC8zNTQ4Mzk3ODYtNzg5Mjk4OWItZTg5Mi00OTYxLTg5YmUtOGMyZDViZWJhM2YzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MDQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODA0VDAwMjM1MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTkzMTkzMDFmNWVjMDUxYjRlZGZiY2JmYzgwN2Y5ZjE0ODhiMGIxM2RlMGU3YTAxODM4OTM1OWUzMzM1OGYyM2YmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.mXB0UzKyeFbdkFSmrP-xkVkjqAmusCDIJhDcFZFhNsw";>
   
   
   
   > > > Thanks for your contributions! By the way, how about adding unit tests 
to cover this code path?
   > > 
   > > 
   > > well, i will add unit test
   > 
   > Great! But could u fix these wrong codestyles in your new code for passing 
the checks. <img alt="image" width="1493" 
src="https://private-user-images.githubusercontent.com/87409330/354839786-7892989b-e892-4961-89be-8c2d5beba3f3.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjI3MzgzNzQsIm5iZiI6MTcyMjczODA3NCwicGF0aCI6Ii84NzQwOTMzMC8zNTQ4Mzk3ODYtNzg5Mjk4OWItZTg5Mi00OTYxLTg5YmUtOGMyZDViZWJhM2YzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MDQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODA0VDAyMjExNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPThjNTM1NjU4ZjA0OGZhMTVkZDhhMDNiNDRhNzA0MmExMjBlMjk3ZThmODFiMDFlZTM2ZmRjMGVhYzg2ZmExZmYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.LlPPVkYTNKyLpDu74eYLwWpixWps9VCnQjQXxuiBPRM";>
   
   done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org