lizhanhui commented on code in PR #809: URL: https://github.com/apache/rocketmq-clients/pull/809#discussion_r1701550443
########## cpp/source/client/include/TelemetryBidiReactor.h: ########## @@ -97,21 +86,21 @@ class TelemetryBidiReactor : public grpc::ClientBidiReactor<TelemetryCommand, Te /// will succeed, and any further Start* should not be called. void OnWriteDone(bool ok) override; - /// Notifies the application that a StartWritesDone operation completed. Note - /// that this is only used on explicit StartWritesDone operations and not for - /// those that are implicitly invoked as part of a StartWriteLast. - /// - /// \param[in] ok Was it successful? If false, the application will later see - /// the failure reflected as a bad status in OnDone and no - /// further Start* should be called. - void OnWritesDoneDone(bool ok) override; +// /// Notifies the application that a StartWritesDone operation completed. Note +// /// that this is only used on explicit StartWritesDone operations and not for +// /// those that are implicitly invoked as part of a StartWriteLast. +// /// +// /// \param[in] ok Was it successful? If false, the application will later see +// /// the failure reflected as a bad status in OnDone and no +// /// further Start* should be called. +// void OnWritesDoneDone(bool ok) override; Review Comment: We may remove it as it's no longer used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
