drpmma commented on code in PR #8368:
URL: https://github.com/apache/rocketmq/pull/8368#discussion_r1666590747
##########
client/src/main/java/org/apache/rocketmq/client/impl/mqclient/MQClientAPIExt.java:
##########
@@ -400,6 +400,48 @@ public CompletableFuture<Void> updateConsumerOffsetOneWay(
return future;
}
+ public CompletableFuture<Void> updateConsumerOffsetAsync(
+ String brokerAddr,
+ UpdateConsumerOffsetRequestHeader header,
+ long timeoutMillis
+ ) {
+ CompletableFuture<Void> future = new CompletableFuture<>();
+ try {
+ RemotingCommand request =
RemotingCommand.createRequestCommand(RequestCode.UPDATE_CONSUMER_OFFSET,
header);
+ this.getRemotingClient().invokeAsync(brokerAddr, request,
timeoutMillis, new InvokeCallback() {
Review Comment:
it's recommended to use invoke method with future sementics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
