dingshuangxi888 commented on code in PR #8231:
URL: https://github.com/apache/rocketmq/pull/8231#discussion_r1623866777
##########
acl/src/main/java/org/apache/rocketmq/acl/plain/PlainAccessResource.java:
##########
@@ -268,7 +269,9 @@ public static PlainAccessResource parse(GeneratedMessageV3
messageV3, Authentica
}
} else if
(NotifyClientTerminationRequest.getDescriptor().getFullName().equals(rpcFullName))
{
NotifyClientTerminationRequest request =
(NotifyClientTerminationRequest) messageV3;
- accessResource.addGroupResourceAndPerm(request.getGroup(),
Permission.SUB);
+ if (StringUtils.isNotBlank(request.getGroup().getName())) {
Review Comment:
It is the same. the UtilAll#isBlank is using StringUtils.isNotBlank
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
