lizhanhui commented on issue #8159: URL: https://github.com/apache/rocketmq/issues/8159#issuecomment-2128394990
This is a place where we can further refine instead of simple keep-or-discard binary decision: 1. Consider the request timestamp and deadline as we may have suspend read for some time: if the request has missed its deadline, request and response should be discarded accordingly; 2. Channel has exposed a method Channel#bytesBeforeWritable(), if the bytes is just over the watermark and less than configurable max-bytes-per-connection, we should keep the response to improve QoS in case of temporary client-side busy, GC for instance; 3. If the outbound inflight bytes within the Channel has exceeds hard limit of the channel buffer, treat it as Amplifciation DDoS Attack and discard the response; -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
