RongtongJin commented on code in PR #8169:
URL: https://github.com/apache/rocketmq/pull/8169#discussion_r1607439114
##########
client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java:
##########
@@ -713,8 +713,10 @@ public void operationFail(Throwable throwable) {
} catch (Exception ex) {
long cost = System.currentTimeMillis() - beginStartTime;
producer.updateFaultItem(brokerName, cost, true, false);
- onExceptionImpl(brokerName, msg, timeoutMillis - cost, request,
sendCallback, topicPublishInfo, instance,
- retryTimesWhenSendFailed, times, ex, context, true, producer);
+ if (!(ex instanceof RemotingTooMuchRequestException)) {
+ onExceptionImpl(brokerName, msg, timeoutMillis - cost,
request, sendCallback, topicPublishInfo, instance,
+ retryTimesWhenSendFailed, times, ex, context, true,
producer);
+ }
Review Comment:
Even if not retried, the onExceptionImpl method should still be executed,
with the retry parameter set to false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
