MR-gwh opened a new issue, #8055:
URL: https://github.com/apache/rocketmq/issues/8055

   ### Before Creating the Enhancement Request
   
   - [X] I have confirmed that this should be classified as an enhancement 
rather than a bug/feature.
   
   
   ### Summary
   
   I think there are unnecessary absolute value operation in class 
TopicPublishInfo. Because method sendQueue.incrementAndGet() must return a 
non-negative number.If possible, I hope I can modify it and make some 
contributions to open source
   <img width="1111" alt="image" 
src="https://github.com/apache/rocketmq/assets/65004897/e6f6f97b-3078-4352-8e1c-5254a3c67d77";>
   <img width="683" alt="image" 
src="https://github.com/apache/rocketmq/assets/65004897/b828a274-d832-4315-bc47-3d559c1cda13";>
   
   
   
   ### Motivation
   
   Reduce unnecessary calculations and consumption
   
   ### Describe the Solution You'd Like
   
   change Math.abs(sendQueue.incrementAndGet() % messageQueueList.size()) to 
sendQueue.incrementAndGet() % messageQueueList.size()
   
   ### Describe Alternatives You've Considered
   
   change Math.abs(sendQueue.incrementAndGet() % messageQueueList.size()) to 
sendQueue.incrementAndGet() % messageQueueList.size()
   
   ### Additional Context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to