cserwen commented on code in PR #8024:
URL: https://github.com/apache/rocketmq/pull/8024#discussion_r1566851399
##########
client/src/main/java/org/apache/rocketmq/client/consumer/MQPullConsumer.java:
##########
@@ -150,6 +149,23 @@ void pullBlockIfNotFound(final MessageQueue mq, final
String subExpression, fina
final int maxNums, final PullCallback pullCallback) throws
MQClientException, RemotingException,
InterruptedException;
+ /**
+ * Pulling the messages through callback function,if no message
arrival,blocking. Support message selection
+ */
+ void pullBlockIfNotFoundWithMessageSelector(final MessageQueue mq, final
MessageSelector selector,
Review Comment:
How about using the `pullBlockIfNotFound` overload directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
