drivebyer commented on code in PR #200:
URL: https://github.com/apache/rocketmq-operator/pull/200#discussion_r1529782794
##########
pkg/controller/broker/broker_controller.go:
##########
@@ -512,6 +500,30 @@ func (r *ReconcileBroker) getBrokerStatefulSet(broker
*rocketmqv1alpha1.Broker,
}
+func getVolumeMounts(broker *rocketmqv1alpha1.Broker, brokerGroupIndex int,
replicaIndex int) []corev1.VolumeMount {
Review Comment:
I understand your point, but it seems that there isn’t much difference with
this method. If users specify ACL configurations in a separate YAML file, they
would still need to maintain common configurations and ACL configurations in
two separate files, even though both are for the broker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
