lizhanhui commented on issue #700: URL: https://github.com/apache/rocketmq-clients/issues/700#issuecomment-1990016939
> I thinks it is more about SDK consistency across different languages. We could fix it like this if you have security concern about "default" in C++. > According to https://github.com/apache/rocketmq/issues/7896, this can be seen as a legacy issue and should be taken care of on SDK side. In fact, Java SDK works by dealing with this case in "default" statement, and so does C# version. So if C++ SDK doesn't work like this, it should be seen as a bug. No. You guys are going to the opposite way. Java and C# DOES NOT CHECK THE REQUIRED FIELD AT ALL. it's not the C++ impl buggy, instead, we need to file pull request to consolidate impls so that they comply with the protocol defined in the [protocol](https://github.com/apache/rocketmq-apis/blob/70eb1effd4b415678fc7214cedd3a289b0f926b9/apache/rocketmq/v2/definition.proto#L107) BTW, there are numerous places where `Endpoints` are used and required fields are checked, are you guys planning to remove all these checks to maintain so-called consistency??? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
