guyinyou commented on code in PR #7860:
URL: https://github.com/apache/rocketmq/pull/7860#discussion_r1503873521


##########
store/src/main/java/org/apache/rocketmq/store/CommitLog.java:
##########
@@ -906,7 +906,7 @@ public CompletableFuture<PutMessageResult> 
asyncPutMessage(final MessageExtBroke
         }
         // Set the message body CRC (consider the most appropriate setting on 
the client)
         msg.setBodyCRC(UtilAll.crc32(msg.getBody()));
-        if (enabledAppendPropCRC) {
+        if (!enabledAppendPropCRC) {

Review Comment:
   __CRC32#This property is reserved by the system. The system only needs to 
add or delete it when enabledAppendPropCRC is true.



##########
store/src/main/java/org/apache/rocketmq/store/CommitLog.java:
##########
@@ -906,7 +906,7 @@ public CompletableFuture<PutMessageResult> 
asyncPutMessage(final MessageExtBroke
         }
         // Set the message body CRC (consider the most appropriate setting on 
the client)
         msg.setBodyCRC(UtilAll.crc32(msg.getBody()));
-        if (enabledAppendPropCRC) {
+        if (!enabledAppendPropCRC) {

Review Comment:
   __CRC32#This property is reserved by the system. The system only needs to 
add or delete it when enabledAppendPropCRC is true.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to