redlsz commented on code in PR #7838:
URL: https://github.com/apache/rocketmq/pull/7838#discussion_r1495522726


##########
proxy/src/main/java/org/apache/rocketmq/proxy/processor/DefaultMessagingProcessor.java:
##########
@@ -124,6 +124,12 @@ public static DefaultMessagingProcessor 
createForClusterMode(RPCHook rpcHook) {
 
     protected void init() {
         this.appendStartAndShutdown(this.serviceManager);
+        this.appendStartAndShutdown(producerProcessor);

Review Comment:
   > It seems that it's not necessary to start processors because this issue is 
only related to receiptHandleManager.
   
   Indeed, this issue is only related to receiptHandleProcessor. But all these 
processors extend AbstractStartAndShutdown and there is no caller, which may be 
error-prone over time?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to