lizhimins commented on code in PR #7816: URL: https://github.com/apache/rocketmq/pull/7816#discussion_r1495333339
########## remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingClient.java: ########## @@ -612,25 +612,33 @@ private void updateChannelLastResponseTime(final String addr) { } } - private Channel getAndCreateChannel(final String addr) throws InterruptedException { + private ChannelFuture getAndCreateChannelAsync(final String addr) throws InterruptedException { if (null == addr) { - return getAndCreateNameserverChannel(); + return getAndCreateNameserverChannelAsync(); } ChannelWrapper cw = this.channelTables.get(addr); if (cw != null && cw.isOK()) { Review Comment: 想了下这里应该不会泄漏 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org