leizhiyuan opened a new issue, #7737:
URL: https://github.com/apache/rocketmq/issues/7737

   ### Before Creating the Bug Report
   
   - [X] I found a bug, not just asking a question, which should be created in 
[GitHub Discussions](https://github.com/apache/rocketmq/discussions).
   
   - [X] I have searched the [GitHub 
Issues](https://github.com/apache/rocketmq/issues) and [GitHub 
Discussions](https://github.com/apache/rocketmq/discussions)  of this 
repository and believe that this is not a duplicate.
   
   - [X] I have confirmed that this bug belongs to the current repository, not 
other repositories of RocketMQ.
   
   
   ### Runtime platform environment
   
   every
   
   ### RocketMQ version
   
   every
   
   ### JDK Version
   
   every
   
   ### Describe the Bug
   
   ```
   2024-01-09 17:31:15 WARN NettyServerCodecThread_3 - event queue size [10001] 
over the limit [10000], so drop this event NettyEvent [type=CLOSE, 
remoteAddr=9.255.72.100:24254, channel=[id: 0xf5169ee0, L:/xxxx:8911 ! 
R:/xxxx:24254]]
   ```
   
   there are many empty value in groupChannelTable
   
   ```
   `---ts=2024-01-09 
17:38:37;thread_name=NettyEventExecutor;id=2f;is_daemon=false;priority=5;TCCL=sun.misc.Launcher$AppClassLoader@58134517
       `---[24.812301ms] 
org.apache.rocketmq.broker.client.ClientHousekeepingService:onChannelClose()
           +---[0.02% 0.004639ms ] 
org.apache.rocketmq.broker.BrokerController:getProducerManager() #72
           +---[99.67% 24.730868ms ] 
org.apache.rocketmq.broker.client.ProducerManager:doChannelCloseEvent() #72
           +---[0.02% 0.004308ms ] 
org.apache.rocketmq.broker.BrokerController:getConsumerManager() #73
           +---[0.03% 0.006361ms ] 
org.apache.rocketmq.broker.client.ConsumerManager:doChannelCloseEvent() #73
           +---[0.01% 0.003326ms ] 
org.apache.rocketmq.broker.BrokerController:getFilterServerManager() #74
           `---[0.01% 0.003547ms ] 
org.apache.rocketmq.broker.filtersrv.FilterServerManager:doChannelCloseEvent() 
#74
   ```
   
   and will more slow with time fly
   
   ### Steps to Reproduce
   
   no need
   
   ### What Did You Expect to See?
   
   normal
   
   ### What Did You See Instead?
   
   leak
   
   ### Additional Context
   
   we can fix inn scanNotActiveChannel, which is a simple way
   
   ```
   Iterator<Entry<String, ConcurrentHashMap<Channel, ClientChannelInfo>>> iter 
= this.groupChannelTable.entrySet().iterator();
           while (iter.hasNext()) {
               Entry<String, ConcurrentHashMap<Channel, ClientChannelInfo>> 
entry = iter.next();
               ConcurrentHashMap<Channel, ClientChannelInfo> chlMap = 
entry.getValue();
               if (chlMap != null && chlMap.isEmpty()) {
                   iter.remove();
               }
           }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to