cserwen commented on code in PR #7647:
URL: https://github.com/apache/rocketmq/pull/7647#discussion_r1424779934
##########
client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPushConsumerImpl.java:
##########
@@ -432,7 +433,11 @@ public void run() {
@Override
public void onException(Throwable e) {
if
(!pullRequest.getMessageQueue().getTopic().startsWith(MixAll.RETRY_GROUP_TOPIC_PREFIX))
{
- log.warn("execute the pull request exception", e);
+ if (e instanceof MQBrokerException && ((MQBrokerException)
e).getResponseCode() == ResponseCode.SUBSCRIPTION_NOT_LATEST) {
+ log.warn("the subscription is not latest, group={},
topic={}", groupName(), topic);
Review Comment:
Maybe errMsg which contains brokerAddr should be logged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
