keranbingaa commented on code in PR #7559: URL: https://github.com/apache/rocketmq/pull/7559#discussion_r1395096989
########## remoting/src/main/java/org/apache/rocketmq/remoting/protocol/body/ConcurrentTopicList.java: ########## @@ -0,0 +1,42 @@ +/* Review Comment: 目前问题是原来的TopicList中改成CopyOnWriteArraySet后,在某些接口调用时,如果topic数很大会有超时的问题,但如果用原来的HashSet则不会有这个问题,新增的需要并发修改的接口则用新增的ConcurrentTopicList这个类,避免并发修改的异常,通过这种方式把两类接口区分开 ########## remoting/src/main/java/org/apache/rocketmq/remoting/protocol/body/ConcurrentTopicList.java: ########## @@ -0,0 +1,42 @@ +/* Review Comment: 目前问题是原来的TopicList中改成CopyOnWriteArraySet后,在某些接口调用时,如果topic数很大会有超时的问题,但如果用原来的HashSet则不会有这个问题,新增的需要并发修改的接口则用新增的ConcurrentTopicList这个类,避免并发修改的异常,通过这种方式把两类接口区分开 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org