ifplusor commented on code in PR #457:
URL:
https://github.com/apache/rocketmq-client-cpp/pull/457#discussion_r1377651905
##########
src/producer/DefaultMQProducerImpl.cpp:
##########
@@ -410,7 +410,7 @@ SendResult
DefaultMQProducerImpl::sendDefaultImpl(MQMessage& msg,
case ComMode_ONEWAY:
return sendResult;
case ComMode_SYNC:
- if (sendResult.getSendStatus() != SEND_OK) {
+ if (sendResult.getSendStatus() != SEND_OK &&
m_retryAnotherBrokerWhenNotStoreOk) {
Review Comment:
Maybe. In Java it is `false`, and I keep it consistent.
https://github.com/apache/rocketmq/blob/26fa0501482bbf31c2a64a33f329ab9744ac3800/client/src/main/java/org/apache/rocketmq/client/producer/DefaultMQProducer.java#L124-L127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
