joeCarf commented on code in PR #7500: URL: https://github.com/apache/rocketmq/pull/7500#discussion_r1374084826
########## remoting/src/main/java/org/apache/rocketmq/remoting/metrics/RemotingMetricsConstant.java: ########## @@ -18,7 +18,6 @@ public class RemotingMetricsConstant { public static final String HISTOGRAM_RPC_LATENCY = "rocketmq_rpc_latency"; - Review Comment: no need to change this line ########## store/src/main/java/org/apache/rocketmq/store/timer/TimerMessageStore.java: ########## @@ -65,10 +43,35 @@ import org.apache.rocketmq.store.config.BrokerRole; import org.apache.rocketmq.store.config.MessageStoreConfig; import org.apache.rocketmq.store.logfile.MappedFile; +import org.apache.rocketmq.store.metrics.DefaultStoreMetricsConstant; Review Comment: too many import changes, and most are not needed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org