RongtongJin commented on code in PR #7502:
URL: https://github.com/apache/rocketmq/pull/7502#discussion_r1372505132
##########
broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java:
##########
@@ -440,6 +440,11 @@ private synchronized RemotingCommand
updateAndCreateTopic(ChannelHandlerContext
return response;
}
+ if
(topicConfig.equals(this.brokerController.getTopicConfigManager().getTopicConfigTable().get(topic)))
{
+ response.setCode(ResponseCode.SUCCESS);
+ return response;
+ }
Review Comment:
It would be better to add a log indicating that the topic already exists and
will no longer be created or updated repeatedly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
